Closed U1F984 closed 1 month ago
The changes made to the Device
class in src/wled/models.py
enhance the version checking process before deserialization. The revised logic validates the version string using an AwesomeVersion
object, ensuring only proper versions are compared. If the version string is invalid or missing, clearer error handling is implemented. The error message has also been updated for better clarity. Overall, these adjustments streamline version validation.
Files | Change Summary |
---|---|
src/wled/models.py | Improved version checking mechanism by validating version strings with AwesomeVersion . Updated error handling and messages. |
Objective | Addressed | Explanation |
---|---|---|
Version check should verify major/minor version only (#1447) | ✅ |
🐇 In the code where versions play,
We check for major, let them stay!
A string so fine, we validate with ease,
Handling errors like a gentle breeze.
WLED's now better, let it gleam and shine,
With versions in sync, all will be fine!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This library does not support forks. There are many forks around, all with their own quirks.
Nevertheless, thanks being willing to contribute.
Fixes #1447
Summary by CodeRabbit