search

frenck / python-wled

Asynchronous Python client for WLED
MIT License
104 stars 28 forks source link

Exception with non-integer values in presets brightness (e.g. bri=~-10) #1449

Closed cvstebut closed 3 days ago

cvstebut commented 1 month ago

Thanks a lot for this library!

I played around with it trying to manage existing devices with the goal of automating setup and configuration.

While testing, I encountered errors with "int" values containing "relative" entries (e.g. bri=\~10) The "\~" allows for setting relative values, for example together with buttons as local UI (one button to increase brightness ("\~10"), another to decrease ("\~-10".)

Expected behavior

No exception thrown :-)

Actual behavior

Exception has occured: InvalidFieldValue

Steps to reproduce

Use the WLED UI to create a preset containing "\~10" e.g. : {"seg":[{"id":3,"bri":"\~-10"}]}

Use this library to the connect: device = await led.update()

Proposed changes

Not sure on this one. At least to degrade gracefully. Ideally the ability to handle these values fully. Change corresponding field types?

github-actions[bot] commented 1 week ago

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!