Fix for event filter - Githubissues

frenck / spook

Spook 👻 Your homie

https://spook.boo

MIT License

360 stars 34 forks source link

Fix for event filter #666

Closed andrew-codechimp closed 1 month ago

andrew-codechimp commented 1 month ago

Description

Fixes upcoming breaking change in 2024.4 as referenced in #665 and https://github.com/home-assistant/core/pull/113798#issue-2194328239

This change makes it backward compatible with previous releases by checking type of event param

Motivation and Context

Solves breaking change in 2024.4

Motivation - I had to fix this myself in Battery Notes so sharing as Spook has been great inspiration for me starting out creating custom components.

How has this been tested?

Tested against current releases prior to 2024.4 only

Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other

Checklist

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

fixes #665

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud