search

frend / frend.co

Frend — A collection of accessible, modern front-end components.
http://frend.co
MIT License
635 stars 25 forks source link

by pass bugs #73

Closed goetsu closed 8 years ago

goetsu commented 8 years ago

Hi,

currently safari still has a bug, internal links doesn't work if target doesn't have a tabindex="-1". So if you want that your script work everywhere you need to had this attribut to the target of the links before to move the focus on it with javascript

thomasdigby commented 8 years ago

Is this on OSX?

goetsu commented 8 years ago

yes and in was in chrome too until last version released

thomasdigby commented 8 years ago

Ok, I'll check it out tonight and update the docs to include a tabindex by default.

adamduncan commented 8 years ago

I'm doing some minor error handling fixes (#84) over on enhancements/bypass-links-target.

While that branch is open, thinking we should address this issue too. Been doing a bit more reading, and as @goetsu said, it's been recently fixed in Chrome, but this test case is still broken in Safari.

The example component on the site does have tabindex="-1" on each anchor by default. Does this mean we just need to update the code example and docs to explain that tabindex is required and the reasons why?

adamduncan commented 8 years ago

Resolved tabindex issues (included as default) with #86 PR. Closing, to revisit as browser implementations are normalised.