search

frend / frend.co

Frend — A collection of accessible, modern front-end components.
http://frend.co
MIT License
635 stars 25 forks source link

Accordion: e.currentTarget instead of e.target #90

Closed gunzip closed 8 years ago

gunzip commented 8 years ago

This will enable having subelements inside accordion trigger / header.

ie. 

    <h2 class="Accordion-header js-fr-accordion__header fr-accordion__header" id="accordion-header-1" >
        <span class="Accordion-link">Open 1</span>
    </h2>
thomasdigby commented 8 years ago

This looks good, can you add the compiled version and we'll merge it in.

adamduncan commented 8 years ago

Nice, thanks. Hey, worth merging the gh-pages master into this fork first, as there were changes to tabs yesterday. A re-commit of tabs.js and /dist/frtabs.min.js, patch bump to v1.0.6 in the package.json and an entry in the changelog should do the trick.

(I'll add some these points in the Contributing notes, as it's not clear at the moment, sorry.)

adamduncan commented 8 years ago

Hey, sorry @gunzip - I had Tabs on the mind, and you're clearly working on Accordion. Thanks for the Changelog/package.json bump. Merging...

adamduncan commented 8 years ago

Thanks for your input. Published to npm @1.0.6