Fix OpenFlow0x04 FlowMod.marshal

frenetic-lang / frenetic

The Frenetic Programming Language and Runtime System

http://www.frenetic-lang.org/

Other

223 stars 51 forks source link

Fix OpenFlow0x04 FlowMod.marshal #525

Closed baxtersa closed 7 years ago

baxtersa commented 7 years ago

Currently, a None value for the mfOut_port field of a flowMod is serialized to 0 during marshaling, but 0 is a valid port number. It should be serialized to OFPP_ANY to match regardless of out_port. I believe mfOut_group has the same issue.

Due to this, the delete_all_flows convenience flowMod doesn't delete all flows.

This fix causes a couple unit tests to break (some marshaling tests are already breaking), but I wanted to bring it up before continuing.

Todo:

[x] Fix out_port marshaling
[ ] Fix out_group marshaling
[ ] Fix unit tests for marshaling

arjunguha commented 7 years ago

This looks good to me. Is anyone else using the 1.3 bindings?

jnfoster commented 7 years ago

Merging.

I'm not actively using 1.3 but it would be great to get 1.3 compiling against the new Plugin API. Happy to have a quick call to go over a few details if that would help.

-N

arjunguha commented 7 years ago

Sure, let's do that. I can talk after Tuesday next week.

On Oct 23, 2016, at 03:11, Nate Foster notifications@github.com wrote:

Merging.

I'm not actively using 1.3 but it would be great to get 1.3 compiling against the new Plugin API. Happy to have a quick call to go over a few details if that would help.

-N

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.