search

frenetic-lang / ocaml-openflow

Serialization library for OpenFlow
Other
13 stars 4 forks source link

cleanup suggestion: Capabilities / capabilities types #19

Open adferguson opened 10 years ago

adferguson commented 10 years ago

hey all,

I noticed that OpenFlow 0x04 and OpenFlow 0x01 have divergent and overlapping coverage for switch capabilities.

for example, 0x01 has SwitchFeatures.Capabilities while 0x04 has both Capabilities and uses types for OpenFlow0x04_Core (flow_stats, table_stats, etc.)

basically, the work to migrate 0x04 to the 0x01-style SwitchFeatures was not completed for the Capabilities elements.

cheers, Andrew

jnfoster commented 10 years ago

I have to confess, I don't understand capabilities at all... but I think you have some expertise at Brown ;-)

Serious

Thanks for all the bug reports. We're in super lock down deadline mode until next week.

On Mon, Nov 11, 2013 at 12:49 PM, Andrew Ferguson notifications@github.comwrote:

hey all,

I noticed that OpenFlow 0x04 and OpenFlow 0x01 have divergent and overlapping coverage for switch capabilities.

for example, 0x01 has SwitchFeatures.Capabilities while 0x04 has both Capabilities and uses types for OpenFlow0x04_Core (flow_stats, table_stats, etc.)

basically, the work to migrate 0x04 to the 0x01-style SwitchFeatures was not completed for the Capabilities elements.

cheers, Andrew

— Reply to this email directly or view it on GitHubhttps://github.com/frenetic-lang/ocaml-openflow/issues/19 .