search

frenetic-lang / pyretic

The Pyretic language and runtime system
http://frenetic-lang.org/pyretic/
159 stars 99 forks source link

virtualization code bug #2 #6

Closed joshreich closed 11 years ago

joshreich commented 11 years ago

the setup is exactly the same as from the original virtualization code bug report. again when the first packet it sent everything breaks. this time w/ TypeError("'module' object is not callable",)

/home/mininet/pyretic/frenetic/netcore.py(402)eval() 401 def eval(self, packet): --> 402 return all(predicate.eval(packet) for predicate in self.predicates) please fix this bug, and verify that example runs properly before closing.

monsanto commented 11 years ago

I of course did verify that example before closing the last ticket, pingall worked fine just as it works fine now. I cannot reproduce your problem. Can you give me some more information? That error doesn't even make sense to me, is the function "all" suggested to be a module? Or is it the eval attribute of some predicate that is now for some reason a module?

You are using my branch of POX, correct?

joshreich commented 11 years ago

I completely believe you, and had been really surprised when it broke when I tried to run it after your fix (and I agree w/ you that the error dump reported in issue #6 (3) seems bizarre). I am using your version of POX (master branch freshly pulled) and to make sure nothing had been subsequently busted, did a git reset --hard e7bfae91225d31250baf2e1cd0831192bcd126ef (the commit where you pushed the fix closing #3).

I definitely think Jen is correct and that the best way for us to figure out what is going on is to schedule a hangout to look at this together as soon as possible. What's the next time you'd be available to chat?

-Josh

On Jan 17, 2013, at 3:27 AM, Christopher Monsanto notifications@github.com wrote:

I of course did verify that example, pingall worked fine just as it works fine now. I cannot reproduce your problem.

— Reply to this email directly or view it on GitHub.

monsanto commented 11 years ago

Any time tomorrow is fine with me (but the later the better). I'm afraid I screwed up my sleep schedule last night.

joshreich commented 11 years ago

Would 1PM work?

On Jan 17, 2013, at 5:03 PM, Christopher Monsanto notifications@github.com wrote:

Any time tomorrow is fine with me (but the later the better). I'm afraid I screwed up my sleep schedule last night.

— Reply to this email directly or view it on GitHub.

monsanto commented 11 years ago

Sure lets do that

joshreich commented 11 years ago

Just saw this, not sure how I missed it. Sorry for the redundancy query in my other email.

On Jan 17, 2013, at 5:14 PM, Christopher Monsanto notifications@github.com wrote:

Sure lets do that

— Reply to this email directly or view it on GitHub.