search

frengor / UltimateAdvancementAPI

A powerful API to create custom advancements for your Minecraft server.
https://modrinth.com/plugin/ultimateadvancementapi
GNU General Public License v3.0
74 stars 5 forks source link

Advancement key not updating properly in online generator #48

Closed JoloJanssen closed 1 year ago

JoloJanssen commented 1 year ago

When you make an advancement and give it a child advancement and after that change the Advancementkey of the parent, the code provided by the online generator only updates half. The new Advancementkey is saved as under the correct variable, but is not carried over to the corresponding "parent" input of the child.

afbeelding_2023-06-21_170920777

Image: These advancements should chain together, but the parent name i not updated in the child creation lines In this example "oak_sapling90" is supposed to be "elemental_magic1".

EscanorTargaryen commented 1 year ago

Thanks for the report, it is a very simple problem to solve, I will do it in the next few days.

EscanorTargaryen commented 1 year ago

The problem only occurred with the RootAdvancement, I should have fixed it. Recreate the RootAdvancement the children from the generator, then it should work.

JoloJanssen commented 1 year ago

I fixed it manually. By setting the parent to something else and back to what its supposed to be it will copy the correct AdvancementKey. Having said that, it didn't occur with just the root advancement, since the image i showed are 3-7 deep in the tree (root=1 here). I will update the issue if I can still reproduce it, but will consider it solved for now.