search

frengor / UltimateAdvancementAPI

A powerful API to create custom advancements for your Minecraft server.
https://modrinth.com/plugin/ultimateadvancementapi
GNU General Public License v3.0
75 stars 5 forks source link

Incorrect annotation on AdvancementKey constructor #60

Closed Fusezion closed 5 months ago

Fusezion commented 6 months ago

When creating a new advancement key from a namespaced key, the annotation is marked as @Nullable when internally you're expecting an @NotNull https://github.com/frengor/UltimateAdvancementAPI/blob/6b7a32660958df6a857afc2972558e982031c36b/Common/src/main/java/com/fren_gor/ultimateAdvancementAPI/util/AdvancementKey.java#L69-L76

frengor commented 6 months ago

Good catch, thank you! We'll fix it in the next release. (we also accept contributions, if you'd like to contribute just make sure to contribute to the dev branch)