Add numeric string literal template to type Number

frenic / csstype

Strict TypeScript and Flow types for style based on MDN data

MIT License

1.7k stars 69 forks source link

Add numeric string literal template to type Number #127

Closed villasv closed 2 years ago

villasv commented 3 years ago

An attempt at issue #125. This breaks compatibility with TS < 4.1 as it relies on template literal types to not open too much the type definition and accept any string.

villasv commented 3 years ago

I'm a bit lost on next steps. From what I understood, we need to introduce a new d.ts for TS > 4.1, but I'm not too familiar with the build process of the project and how the maintainers would like to evolve it.

frenic commented 3 years ago

I've tested it and it seems to work as expected without breaking autocomplete! But as you mention we need some additional changes on the builds before we can merge this. I hope I can spare some time for this soon.

villasv commented 2 years ago

Closing as stale, maybe some day this can be picked up.