search

frenic / csstype

Strict TypeScript and Flow types for style based on MDN data
MIT License
1.7k stars 69 forks source link

Support for Container Queries #175

Open KoltonG opened 1 year ago

KoltonG commented 1 year ago

👋 Hey Team! Given that CSS Container Queries is near supported in all major browsers, it would be great to have CSS typing for it.

I tried to fork and add it myself, however, the mdn/data repo does not include their typings. That repository also notes the following:

Note We are in the process of deprecating the mdn/data package in favor of w3c/webref. If you depend on this project, let us know in our community GitHub discussions. Thank you.

This might be the reason why it was not updated. The referred repository, w3c/webref, does have typing for CSS Container Queries via https://github.com/w3c/webref/blob/1a31f07e1814cf8919c0dd87023aaab20cd84a14/ed/css/css-contain-3.json

What would you recommend as the next steps to get CSS Container Queries typing into this package?

meyer commented 1 year ago

seems like the real issue here is "migrate mdn/data to w3c/webref". the next step would probably be something along those lines.

KoltonG commented 1 year ago

Agreed @meyer! This does seem to be a much bigger rabbit hole 🐰 than simply adding the typing 🙈 Wondering if this was something the team was planning to do anyhow or is this the first request?

bdow commented 11 months ago

Looks like this may be fixed as of v 3.1.2. https://github.com/frenic/csstype/commit/40440cd290162aa2b21d9691b4d27e5e0fa038b3 Maybe can close now?

valterkraemer commented 10 months ago

Updating to 3.1.2 fixed it for me!