Still missing sources in repository

[GoogleCodeExporter]

Building 86280e7a2f49:

/home/pfalcon/projects-active/android/fdroid/pfalcons-fdroidserver/build/com.wri
te.Quill/jni/org_libharu_Document.cpp:1:34: error: org_libharu_Document.h: No 
such file or directory

Original issue reported on code.google.com by pmis...@gmail.com on 20 Feb 2012 at 10:08

[GoogleCodeExporter]

Its an autogenerated header. Look at the build.sh script for details.

Original comment by vbraun.n...@gmail.com on 20 Feb 2012 at 11:16

• Changed state: Invalid

[GoogleCodeExporter]

Oops, that's better, thanks. There's still room for improvement though:

====
pushd /home/vbraun/Eclipse/workspace/Quill
...
/home/vbraun/opt/android-ndk-r6b/ndk-build
====

Somehow I and many other folks don't have those paths around. Maybe you at 
least could assume it's in the PATH and that dir is current. Or maybe even 
better would be to add README with:

====
You start building Quill with running generate.sh and then follow as with any 
other Android application:

ndk-build
ant debug
====

Just thinking aloud though...

Original comment by pmis...@gmail.com on 20 Feb 2012 at 11:45

[GoogleCodeExporter]

Oh, and having obj/local/armeabi/objs/ in hg is probably really superfluous - 
producing a lot of spurious hg diff's. Thanks again!

Original comment by pmis...@gmail.com on 20 Feb 2012 at 11:47

[GoogleCodeExporter]

I checked in the compiled ARM library specifically since not everybody will 
want to mess with the NDK.

Original comment by vbraun.n...@gmail.com on 20 Feb 2012 at 11:51

[GoogleCodeExporter]

Actually, I figure you need compiled classes to run javah. But there's no 
support with android ant targets to just compile classes! (the target is 
"-compile", so cannot be called from command line). So, it would be 2-pass 
process: run "ant debug" to compile classes (and produce broken apk!), run 
build.sh, run ant debug again. Summing up... could you please just check that 
file in? It would be nice to keep build.sh around for folks who will hack on 
jni side of things, but uncomplicating typical build process would be a boon!

Original comment by pmis...@gmail.com on 21 Feb 2012 at 12:09

[GoogleCodeExporter]

> I checked in the compiled ARM library specifically since not everybody will 
want to mess with the NDK.

Thanks, but there's big difference between source file (even autogenerated) and 
binary file. Some may want to build lib with their own compiler optimization 
flags. Some will carefully review your source code for your app wanting to 
steal their credit card info, but can't really do that easily for binary blobs.

That's the whole point of open source, isn't it?

Original comment by pmis...@gmail.com on 21 Feb 2012 at 12:13

[GoogleCodeExporter]

Eclipse builds the classes just fine, even if the library hasn't been compiled 
yet. I never tried to use just ant on the command line. Are you sure you are 
not just missing some switch in ant.

I wouldn't mind removing any binaries from the repo but, come to think of it, 
this was probably just the eclipse default. 

Original comment by vbraun.n...@gmail.com on 21 Feb 2012 at 12:21

[GoogleCodeExporter]

Yep, I even looked it up on StakeOverflow: 
http://stackoverflow.com/questions/4256958/command-line-to-run-the-ant-task-with
-hyphen-in-the-task-name . It specifically quotes Ant docs that hyphen-prefixed 
target can't be called from command line, though IDEs may get around that. But 
I'm using ant and working on automated build system (f-droid.org). So IMHO, 
having org_libharu_Document.h and friends committed would be a good compromise. 
Thanks for your support!

Original comment by pmis...@gmail.com on 21 Feb 2012 at 12:33

[GoogleCodeExporter]

I checked the autogenerated headers into the repo.

Original comment by vbraun.n...@gmail.com on 21 Feb 2012 at 1:10

• Changed state: Done