search

frenya / vscode-recall

MIT License
24 stars 7 forks source link

Local Assets/Images Fail to Render #15

Closed sam-6174 closed 1 year ago

sam-6174 commented 1 year ago

Thanks again for maintaining this great plugin; I really like the ability in the recent version to control CSS styling.

However, it seems that v0.12 has an issue where local images fail to render. This was working fine in the prior version.

Local images display correctly when a card is viewed via VS Code's built-in Markdown: Open Preview.

This has been reproduced on a completely fresh install of VS Code, with no other extensions installed. I have tried toggling on/off the various built-in markdown styles (shown below) to no avail.

Below is an example flashcard. The URL images display just fine, but local images (both relative and absolute paths) fail to display.

---
recall: header
---

### URL Test

![Markdown Picture](https://picsum.photos/id/237/536/354)

<img src="https://picsum.photos/seed/picsum/536/354" width="300">

### Relative Local Test

![Markdown Picture](./assets/image.png)

<img src="./assets/image.png" width="300">

### Absolute Local Test

![Markdown Picture](/Users/sam/recall_test/assets/image.png)

<img src="/Users/sam/recall_test/assets/image.png" width="300">

Failed images look like this:

frenya commented 1 year ago

Hi. It is fixed in v0.12.2. Thanks for reporting this.

sam-6174 commented 1 year ago

Thanks for the fix, working perfectly now.