search

frenzyapp / turbolinks

Turbolinks is a direct port of the rails turbolinks gem and the jquery.turbolinks gem for projects using the Laravel 4.1+.
MIT License
163 stars 13 forks source link

Laravel 5 support #6

Closed tortuetorche closed 9 years ago

tortuetorche commented 9 years ago

Hi @MathieuDoyon,

Few months ago, I forked your repository to integrate it with my Larasset package, which is an assets manager. And now I've updated my turbolinks fork to support Laravel 5.

Here an online demo to see it in action with Laravel 5 and Larasset.

Maybe we can merge our repository? Because my fork has just a different installation instructions in the README.md and a line in the ServiceProvider to automagically load turbolinks assets with the Larasset package.

If you agree, I could send you a pull request by the end of the week. With an additional README_LARASSET.md file.

Merci d'avance, Tortue Torche

MathieuDoyon commented 9 years ago

Yes absolutely. Send me your PR, I will merge it to support L5

tortuetorche commented 9 years ago

I forgot to mention that there is some drawbacks, my Laravel 5 support isn't backward compatible with Laravel 4. IMO, the best solution is to create two git branches. I already do this in my tubolink fork:

Are you OK with that?

tortuetorche commented 9 years ago

Hi @MathieuDoyon,

Can you create a new branch, please? Then I'll send a pull request to it.

A+, Tortue Torche

MathieuDoyon commented 9 years ago

https://github.com/frenzyapp/turbolinks/tree/L5

tortuetorche commented 9 years ago

:+1:

tortuetorche commented 9 years ago

See #7