freqtrade / freqtrade-strategies

Free trading strategies for Freqtrade bot
GNU General Public License v3.0
3.23k stars 1.1k forks source link

Strategies do not work on new versions #247

Closed vladroots closed 2 years ago

vladroots commented 2 years ago

Please update the code for new versions freqtrade

xmatthias commented 2 years ago

This is incorrect, the strategies will also work with new versions of freqtrade as long as you stick to spot markets. Otherwise, please provide logs (and the strategy) on the error you're encountering.

As most strategies were designed for spot markets anyway, i don't see an urgent need to update all strategies.

vladroots commented 2 years ago

There, everywhere you need to change for new configs, changes between V2 and V3 backtesting does not work

xmatthias commented 2 years ago

I've just sample-backtesed a few of the strategies in this repo with the latest develop version without problems.

If you think there's a problem, please share logs of it (and with which version / strategy it's happening).

vladroots commented 2 years ago

how to determine which strategies for spot and which strategies for futures?

xmatthias commented 2 years ago

Currently all strategies provided here are for spot, except for the strategies in the /futures directory.

Please note that we do not guarantee profits for ANY of the provided strategies, as they are supposed to serve as sample - not as "ready to be rich" strategy.

caglarylmz commented 2 years ago

I tested spot strategies and didnt seen any problem.

Tested with latest freqtrade version with docker image. If you share your strategy and config file, I can help.

vladroots commented 2 years ago

Thank you! Solved the problem. Installation with Conda helped. Everything worked.

vladroots commented 2 years ago

Tell me the basis for the strategy of a reversal pattern, for example, this http://joxi.ru/J2b1Q8Zc0NGXqm Or a signal when increasing the volume before the pump Or a signal when increasing the volume before the pump http://joxi.ru/gmvqN4EhqavLKr

EdvinLndh commented 2 years ago

This is incorrect, the strategies will also work with new versions of freqtrade as long as you stick to spot markets. Otherwise, please provide logs (and the strategy) on the error you're encountering.

As most strategies were designed for spot markets anyway, i don't see an urgent need to update all strategies.

I was also getting some errors when trying to run these strategies. For example, when running the trade command with Strategy004 I got an error saying that deprecated methods and variables are used. My very basic fix was to change 'sell' to 'exit' and 'buy' to 'entry' throughout the strategy on these methods and variables. The terminal was quite accurate in telling what the errors where.

xmatthias commented 2 years ago

I was also getting some errors when trying to run these strategies.

this will only happen if you use a configuration made for futures (trading_mode="futures")

EdvinLndh commented 2 years ago

I see, it was just me being a total newbie then. Cheers!

daidat commented 2 years ago

I met with the same problem because of I just use my file name as the strategy name and forget to change the python class name

xmatthias commented 2 years ago

All strategies have now been updated to the new interface.

As such i'll be closing this issue.