xmatthias
commented
4 years ago Please check the logs for any message > INFO level which did happen in the timeframe (+-1-2 minutes) of this trade. Maybe some update or whatnot failed.
For the buy side: the Buy telegram message is sent when the buy order is created. Fees are not known at that point - so the buy message is working as intended (it's sending you all information known at that point in time).
for the fee handling itself - this is a known issue to some regard (#2649) - and especially applies when non-standard fees are applied. The issue itself proposes to move this to the users responsibility, which i disagree with - but i didn't yet have time to fully dig into this.
To help in aligning the fee handling between all exchanges, the following data would be helpful - as this should contain the information on fees applied.
import ccxt
from datetime import datetime
ct = ccxt.bittrex({'apiKey': '<key>', 'secret': '<secret>'}
ct.load_markets()
since = int(datetime(2020,4,1).timestamp() * 1000)
res= ct.fetch_my_trades('BTC/USD', since=since)
print(res)Feel free to remove all trades which are not the above - i'll really just need one buy, and one sell trade (which ideally align).
mostlyvirtual
IpsissimusMarr
hroff-1902
Step 1: Have you search for this issue before posting it?
Yes, I've searched for this issue, and also discussed it in Slack.
Step 2: Describe your environment
Step 3: Describe the problem:
The profit/loss is not accurate in the buy/sell messages, nor is it accurate then in /performance or /daily.
Steps to reproduce:
Observed Results:
When the coin was bought the bot said that it spent 40 USD, but Bittrex order history reports 40.03994587. Quite possible that the extra amount is the fee, but I think the bot should account for that if I understand correctly? When the coin was sold, the bot said that the trade lost money, but it actually made a profit, even including the fees.
I expected the buy/sell orders to account for the fees, and at the end to report accurate profit/loss percentage.
Relevant code exceptions or logs:
Scenario 1
Bot sends following Telegram message:
When checking Bittrex order history, we can see the 'Open Rate' and 'Amount' are accurate, but the 'Total' is not:
When it tried to close this trade, it sent the following Telegram message:
When checking Bittrex order history, we can see that it actually made a profit:
If we do 0.00642194 BTC x 6,242.39699997 USD = 40.08829898998734 USD If we do 40.08829898998734 USD (total money credited to account after sell) - 0.04008829 (sell commission) = 40.04821070 USD - 0.03999994 USD (commission on buy order) = 0.00826483 USD (our massive profit) which means that we made a profit of 0.02%, not a loss of -0.28%.
I've observed this with other orders, as it can be seen clearly in the order history window, especially when sell order is right after buy order.
In the next screenshot, the bot reported a loss of 0.33%, but the loss was really 1.66%:
In the next screenshot, the bot reported a profit of 0.17%, but in fact it was 0.49%
Finally, in closing, I want to mention that it happens with other pairs as well, not just USD/BTC.