search

freqtrade / technical

Various indicators developed or collected for the Freqtrade
GNU General Public License v3.0
762 stars 218 forks source link

Chikou Span (Ichimoku Cloud Lagging Price) #12

Closed MichealReed closed 4 years ago

MichealReed commented 5 years ago

I plan to raise this as a different issue in the freqtrade repo, but the way the chikou span is implemented allows the backtesting engine to look at future data. Chikou is only supposed to be a visual indicator for plotting the current price 26-30 ticks back on the chart.

xmatthias commented 4 years ago

We've since added a warning noting to not use chikou_span for backtesting to the method's dostring.

https://github.com/freqtrade/technical/blob/9924ee42a46811ce33bd46ab760d00a6cd0e48b0/technical/indicators.py#L247-L260

The main problem with ichimoku cloud is that it's a visual indicator (designed for people to look at charts) - and not necessarily for algo trading. While i CAN be used for that - it needs to be done in a carefull manner.

I don't think we should remove this line, as it IS part of ichimoku cloud - and can be quite usefull when used in plotting.

Hope this makes sense.