frequency-chain / frequency-xyz

Frequency Website
Apache License 2.0
2 stars 1 forks source link

update deps and fix warnings #29

Closed shannonwells closed 2 weeks ago

shannonwells commented 3 weeks ago

Description

Updates a bunch of packages including Svelte 5, and other major versions. Fixes some warnings.

Type of change

How to Test?

Click on the latest preview deployment link, below.

  1. Verify it runs/doesn't crash, doesn't have warnings
  2. Click through the numerical slides and verify they all work
  3. Click the right side tab and make sure that shows up
  4. click around elsewhere

Checklist:

github-actions[bot] commented 3 weeks ago

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/29/ Commit: 14504df

github-actions[bot] commented 3 weeks ago

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/29/ Commit: b77f83a

shannonwells commented 2 weeks ago

Question: Are there not other changes we needed to make for Svelte v5? I guess they aren't required based on the style guide, but perhaps we need an issue to remember to go back and update everything?

While their migration script didn't work, they also said most projects can upgrade and just fix errors and warnings. I looked over some of the migration notes for Svelte5, and this repo wasn't really using anything that was affected by the breaking changes (e.g. svelte:component is now svelte:element). I fixed all of the warnings and errors.

wilwade commented 2 weeks ago

@shannonwells Sounds good. Merge it!