frequency-chain / frequency

Frequency: A Polkadot Parachain

https://www.frequency.xyz

Apache License 2.0

48 stars 18 forks source link

rpc: expose missing nonces in future pool #1973

Closed aramikm closed 1 month ago

aramikm commented 2 months ago

Goal

The goal of this PR is to expose missing nonces in future pool which causes problems when submitting a lot of transactions from the same account.

Closes #1974

Discussions

I had to remove node RPC test for events, since the setup fundamentally didn't work with the Pool and I added the removed test into e2e side.

Checklist

[X] Chain spec updated
[X] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
[X] Tests added

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

enddynayn commented 1 month ago

LGTM. However, I’m a bit unclear on how this will benefit the client. It might be more effective for the client to keep track of transactions that have not yet been processed.

aramikm commented 1 month ago

LGTM. However, I’m a bit unclear on how this will benefit the client. It might be more effective for the client to keep track of transactions that have not yet been processed.

This will allow them to see if there are any transactions that are submitted using incorrect nonces. Tracking submitted transactions is not enough considering there might be more than 1 instance using the same account submitting to the chain.