frequency-chain / frequency

Frequency: A Polkadot Parachain
https://www.frequency.xyz
Apache License 2.0
48 stars 18 forks source link

[Passkey]: Use pallet transaction payment directly for `pre_dispatch` and `validate` for Passkey #2051

Open saraswatpuneet opened 5 days ago

saraswatpuneet commented 5 days ago

Feature Description

Details

From discussion on PR #2029

I have a question regarding the code. Could you please explain why we don’t call pre_dispatch here?||

pallet_transaction_payment::ChargeTransactionPayment::::pre_dispatch()? Member Author @saraswatpuneet saraswatpuneet 1 hour ago ChargeTransactionPayment does not expose those functions SignedExtension trait does so we cant directly use it here

Hence we had to do this redundant implementation of check nonce and this

Member @enddynayn enddynayn 1 hour ago • I believe that SignedExtension is implemented on ChargeTransactionPayment. We may just need to import the trait to use it. Could there be a name collision causing the issue?

Member Author @saraswatpuneet saraswatpuneet 1 hour ago Will give it try

Possible Related Issues

-

Searched for Related Issues