frequenz-floss / frequenz-api-common

Shared protobuf definitions and Python bindings for Frequenz APIs
https://frequenz-floss.github.io/frequenz-api-common/
MIT License
1 stars 12 forks source link

Gap in `COMPONENT_CATEGORY_XXX` tags #254

Open llucax opened 2 months ago

llucax commented 2 months ago

What's needed?

Not sure if we want to fix this, but there a gap between COMPONENT_CATEGORY_EV_CHARGER and COMPONENT_CATEGORY_CRYPTO_MINER:

  // A station for charging electrical vehicles.
  COMPONENT_CATEGORY_EV_CHARGER = 6;

  // A crypto miner.
  COMPONENT_CATEGORY_CRYPTO_MINER = 8;

Proposed solution

Maybe make it contiguous?

  // A station for charging electrical vehicles.
  COMPONENT_CATEGORY_EV_CHARGER = 6;

  // A crypto miner.
  COMPONENT_CATEGORY_CRYPTO_MINER = 7;

  // An electrolyzer for converting water into hydrogen and oxygen.
  COMPONENT_CATEGORY_ELECTROLYZER = 8;

  // ...

We would need to shift all the following tags too (we have until 15, if we shift if will be until 14).

tiyash-basu-frequenz commented 2 months ago

Sure, we can take these in the next breaking change release.