search

frequenz-floss / frequenz-api-dispatch

gRPC+protobuf specification and Python bindings for the Frequenz Dispatch API
https://frequenz-floss.github.io/frequenz-api-dispatch/
MIT License
1 stars 6 forks source link

"Yearly" frequency missing from recurrence rule #157

Closed stefan-brus-frequenz closed 3 months ago

stefan-brus-frequenz commented 5 months ago

What happened?

The "yearly" frequency is not available in the current Recurrence Rule definition, making the bymonths field redundant.

What did you expect instead?

"Yearly" should be added to the frequency enum. See the RFC: https://datatracker.ietf.org/doc/html/rfc5545

Affected version(s)

No response

Affected part(s)

The protocol buffer definition files (part:protobuf)

Extra information

No response

thomas-nicolai-frequenz commented 5 months ago

The enum needs extending like this:

  enum Frequency {
    FREQUENCY_UNSPECIFIED = 0;
    FREQUENCY_MINUTELY = 1;
    FREQUENCY_HOURLY = 2;
    FREQUENCY_DAILY = 3;
    FREQUENCY_WEEKLY = 4;
    FREQUENCY_MONTHLY = 5;
+  FREQUENCY_YEARLY = 6;
  }