search

frequenz-floss / frequenz-api-dispatch

gRPC+protobuf specification and Python bindings for the Frequenz Dispatch API
https://frequenz-floss.github.io/frequenz-api-dispatch/
MIT License
1 stars 6 forks source link

Do not allow updating dispatch `type` #158

Closed thomas-nicolai-frequenz closed 3 months ago

thomas-nicolai-frequenz commented 5 months ago

What's needed?

Remove support for changing the dispatch type after creation.

Proposed solution

// Message to update the dispatch with the given ID, with the given attributes
message DispatchUpdateRequest {
  // Message containing the updated dispatch attributes
  message DispatchUpdate {
       ...
    }

-    // The type of dispatch
-    optional string type = 1;

Use cases

A user should not be able to change the dispatch type after creation as this would mean handing over an existing dispatch from one actor to another.

Alternatives and workarounds

Delete dispatch and create a new one instead of trying to update the type of an existing dispatch.

Additional context

No response

Marenz commented 3 months ago

done in https://github.com/frequenz-floss/frequenz-api-dispatch/pull/172