search

frequenz-floss / frequenz-api-dispatch

gRPC+protobuf specification and Python bindings for the Frequenz Dispatch API
https://frequenz-floss.github.io/frequenz-api-dispatch/
MIT License
1 stars 6 forks source link

Document valid values for `count` and `interval` #179

Closed Marenz closed 2 months ago

Marenz commented 3 months ago

The values are chosen based on the limits set by the rrule library used in the service, see:

https://github.com/fmeringdal/rust-rrule?tab=readme-ov-file#limitation-and-limits

4096 was chosen as it seemed large enough for any sane usecase but not large enough to cause DoS for the service.

refs https://github.com/frequenz-io/frequenz-service-dispatch/issues/122 refs https://github.com/frequenz-io/frequenz-service-dispatch/issues/78

Marenz commented 2 months ago

Apart from this nice discussion, can we merge this?