search

frequenz-floss / frequenz-api-microgrid

gRPC+protobuf specification and Python bindings for the Frequenz Microgrid API
https://frequenz-floss.github.io/frequenz-api-microgrid/
MIT License
6 stars 6 forks source link

Bump the api-common dependency to v0.5.4 #205

Closed llucax closed 9 months ago

llucax commented 10 months ago

The new v0.5.4 release of the api-common repository is now backwards compatible with the old v0.3.x releases. We bump the dependency so microgrid API can be used together with other APIs that depend on the newer common API version.

Please note that the googleapis-common-protos dependency is also bumped to v1.56.4, which is the version that api-common v0.5.4 depends on.

Strictly speaking, this is a breaking change too, as projects might need to bump their googleapis-common-protos dependency to v1.56.4 too if they specify it explicitly, but this is highly unlikely and very easy to fix.

llucax commented 10 months ago

I'm not sure why tests are not being run here... :thinking:

llucax commented 10 months ago

I guess it was because I made the PR originally against the wrong branch, now I force-pushed and they are running...

llucax commented 10 months ago

This needs updating the dependency when common API v0.5.4 is released. The test with nox CI check also fails because we need a release of common API v0.5.4 first for it to pass (otherwise it can't parse the minimum version from the string).

The tests that are not running are just because we are in an old branch that used different check names.

llucax commented 9 months ago

API common v0.5.4 was released, so this PR is updated too and ready for review (and merge).

llucax commented 9 months ago

FYI, there are a couple of CI checks that are expected but will never run because they are not present in this branch, but all tests are passing. We'll need to force-merge once this is approved.

llucax commented 9 months ago

I will force-merge this, as the tests will never complete.