search

frequenz-floss / frequenz-api-microgrid

gRPC+protobuf specification and Python bindings for the Frequenz Microgrid API
https://frequenz-floss.github.io/frequenz-api-microgrid/
MIT License
6 stars 6 forks source link

Make `AddComponentBounds` more consistent with other RPCs #270

Open llucax opened 2 weeks ago

llucax commented 2 weeks ago

The AddComponentBoundsRequest.validity_duration field was replaced by AddComponentBoundsRequest.request_lifetime to match the fields in SetComponentPowerActiveRequest and SetComponentPowerReactiveRequest. The default value was also changed from 5 to 60 seconds.

The AddComponentBoundsResponse.ts field was renamed to AddComponentBoundsResponse.valid_until for extra clarity and also to match the fields in SetComponentPowerActiveResponse and SetComponentPowerReactiveResponse.

Fixes #269.

llucax commented 2 weeks ago

I updated the defaults to match the ones in SetComponentPower*, but I'm not sure we really want to do that, it is a big difference.