Revamp modules structure - Githubissues

frequenz-floss / frequenz-channels-python

Channel implementations for Python

https://frequenz-floss.github.io/frequenz-channels-python/

MIT License

7 stars 8 forks source link

Revamp modules structure #235

Closed llucax closed 11 months ago

llucax commented 11 months ago

Remove Bidirectional channel
Remove Peekable and associated methods/classes
Don't import TypeVars from other modules
Make all TypeVars private
Split _base_classes into _receiver and _sender
Make channels return the base sender and receiver types
Make channel's sender and receiver implementation private
Don't use aliases for the base sender and receiver classes
Move merge and select symbols to the top level
Move utility receivers to their own public modules
Move nested class out of the parent class

Fixes #233, fixes #234.

llucax commented 11 months ago

Added release notes, this is ready for the final review.

shsms commented 11 months ago

Just one comment, looks good otherwise.