search

frequenz-floss / frequenz-client-base-python

Base gRPC client
https://frequenz-floss.github.io/frequenz-client-base-python/
MIT License
0 stars 3 forks source link

Allow passing SSL options via server URL #73

Closed llucax closed 1 month ago

llucax commented 1 month ago

Need some tests, but other than that it is ready for review.

Marenz commented 1 month ago

Looks like it should work. I'll try to use it and will report

Marenz commented 1 month ago

Works well in my test!

llucax commented 1 month ago

OK, this PR was reworked a lot, and now we allow client implementors to set defaults for creating gRPC channels much more flexibly. For example, a default root certificates option can be passed both as a file path or bytes. The users also have the option to override these options via the URL.

Marking as ready to review.

llucax commented 1 month ago

@Marenz can you re-test and give this a (final?) review?

llucax commented 1 month ago

Tests are failing because some breaking change in griffe when generating docs, will look at it ASAP but the review can be done anyways

llucax commented 1 month ago

Fixed the CI failure.