search

frequenz-floss / frequenz-client-common-python

Python bindings for the shared Frequenz API messages
MIT License
0 stars 4 forks source link

Add microgrid types #14

Closed flora-hofmann-frequenz closed 6 months ago

flora-hofmann-frequenz commented 8 months ago

Split up of types modules to reflect protobuf structure.

llucax commented 8 months ago

I made some similar comments in:

I think we should focus on the review of only one and delay the review of the other after that, because I think there will be a lot of duplicate comments.

Since I made quite a few comments to #15 and most comments done here are also covered there, I suggest to start with #15. I will make this a draft PR to make this clear. If you don't agree please feel free to change it back to a final PR.

flora-hofmann-frequenz commented 6 months ago

Closed as this will also be changed in connection with reporting client mvp.