search

frequenz-floss / frequenz-client-common-python

Python bindings for the shared Frequenz API messages
MIT License
0 stars 4 forks source link

Add pagination types #15

Closed flora-hofmann-frequenz closed 7 months ago

flora-hofmann-frequenz commented 8 months ago

Split up type modules to reflect protobuf structure.

flora-hofmann-frequenz commented 7 months ago

@cwasicki We have decided to start with this PR and then change #8 and #14 accordingly - see (https://github.com/frequenz-floss/frequenz-client-common-python/pull/14#issuecomment-1935550822).

flora-hofmann-frequenz commented 7 months ago

Maybe someone can help me to find out why mypy is still failing?

llucax commented 7 months ago

Maybe someone can help me to find out why mypy is still failing?

I think the import is incorrect:

src/frequenz/client/common/pagination/init.py:12: error: Skipping analyzing "frequenz.api.common.v1.pagination_info_pb2

Shouldn't it be frequenz.api.common.v1.pagination.pagination_info_pb2?

>>> import frequenz.api.common.v1.pagination_info_pb2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'frequenz.api.common.v1.pagination_info_pb2'
>>> import frequenz.api.common.v1.pagination.pagination_info_pb2
llucax commented 7 months ago

This is still waiting for a GPG signature for the commit @flora-hofmann-frequenz