search

frequenz-floss / frequenz-client-dispatch-python

Dispatch API client for Python
https://frequenz-floss.github.io/frequenz-client-dispatch-python/
MIT License
0 stars 2 forks source link

Fix the Python package name #27

Closed llucax closed 3 months ago

llucax commented 3 months ago

The name should be frequenz-client-dispatch instead of frequenz-dispatch-client.

llucax commented 3 months ago

Fortunately there is no pypi release, so we don't need to fix anything in pypi.

llucax commented 3 months ago

@Marenz maybe it is a good time to make a pypi account and do a v0.1.0 release?

https://frequenz-floss.github.io/frequenz-repo-config-python/v0.10-dev/user-guide/start-a-new-project/configure-pypi/

Marenz commented 3 months ago

No, both things already happened before your PR even :P

https://github.com/frequenz-floss/frequenz-client-dispatch-python/releases/tag/v0.1.0

However the releasing on pypi didn't work, probably because this PR was missing.

llucax commented 3 months ago

No, it failed because you are using git dependencies, pypi needs every dependency available in pypi:

https://github.com/frequenz-floss/frequenz-client-dispatch-python/actions/runs/8006394682/job/21869043552#step:4:26

I guess it is still a good thing that it failed.

Marenz commented 3 months ago

Oh right, I remember now :sweat_smile: