Interface fixes & enhancements

frequenz-floss / frequenz-client-dispatch-python

Dispatch API client for Python

https://frequenz-floss.github.io/frequenz-client-dispatch-python/

MIT License

0 stars 2 forks source link

Interface fixes & enhancements #33

Closed Marenz closed 2 months ago

Marenz commented 2 months ago

Fix start_time conversion imprecision bug
Rename client-side create request fields is_{active,dry_run}
Make .create() return the new created dispatch

Marenz commented 2 months ago

Updated:

always return Dispatch in create now (no parameter
use dict of CreateRequest for attribute comparison
Added explanation for time bug

leandro-lucarella-frequenz commented 2 months ago

Oh dear, it seems like I lost a in-process review. I will try to recreate what I remember. I suggest opening a new PR with the new commits, as they are not really necessary to be in this PR and we were close to finish the review. I have a few comments for the new commits and that will make merging this Pr more time consuming.

Oh, damn, I was logged with the wrong user to do some admin tasks... :facepalm:

llucax commented 2 months ago

I suggest opening a new PR with the new commits, as they are not really necessary to be in this PR and we were close to finish the review. I have a few comments for the new commits and that will make merging this PR more time consuming.

llucax commented 2 months ago

Added explanation for time bug

Awesome, thanks! Now I remember.

Marenz commented 2 months ago

Responded to comment and removed the unrelated commits

shsms commented 2 months ago

Ok, LGTM then.

Marenz commented 2 months ago

Re-opeening as github seems very bugged now.

shsms commented 2 months ago

Probably needs a rebase?