search

frequenz-floss / frequenz-client-dispatch-python

Dispatch API client for Python
https://frequenz-floss.github.io/frequenz-client-dispatch-python/
MIT License
0 stars 2 forks source link

Fail the `nox-cross-arch-all` job if any matrix job fails #43

Closed llucax closed 2 months ago

llucax commented 2 months ago

Otherwise this job will be skipped, just like when the matrix jobs are skipped, resulting in a passed check when it should have failed.

llucax commented 2 months ago

Oh, @leandro-lucarella-frequenz is not a repo owner, so the approval doesn't count. @daniel-zullo-frequenz maybe you can approve it?

daniel-zullo-frequenz commented 2 months ago

I've approved it but it seems it didn't help

llucax commented 2 months ago

Oh, right, the codeowner here is the @frequenz-floss/api-dispatch-team, not the SDK team, that's why... @stefan-brus-frequenz or @ktickner maybe can approve this? I guess we should make the SDK team an owner too...

llucax commented 2 months ago

I added a commit to make the SDK team a code owner too.

llucax commented 2 months ago

We still need to merge this PR for the SDK team to be able to approve.

llucax commented 2 months ago

God dammit, the merge queue doesn't seem to be working at all :unamused:

llucax commented 2 months ago

But at least it seems to work: https://github.com/frequenz-floss/frequenz-client-dispatch-python/actions/runs/8936033687