search

frequenz-floss / frequenz-client-dispatch-python

Dispatch API client for Python
https://frequenz-floss.github.io/frequenz-client-dispatch-python/
MIT License
0 stars 2 forks source link

Don't recursively scan for pyproject.toml when calculating the cache key #44

Closed llucax closed 2 months ago

llucax commented 2 months ago

Don't recursively scan for pyproject.toml when calculating the cache key

We don't really need to scan for pyproject.toml files recursively, since we only have one in the root of the repository. This should make the cache key calculation more efficient and less error prone, as when using qemu, there are some files that are not accessible and the hash calculation fails.

llucax commented 2 months ago

Mmm, maybe putting the SDK team as an owner wasn't the best approach, as it now asks for a review to the SDK team too, which might be too much. What do you think? Ideally I would like that SDK team members can approve but are not asked for a review automatically.

daniel-zullo-frequenz commented 2 months ago

I would like that SDK team members can approve but are not asked for a review automatically.

I agree that'd be the best