search

frequenz-floss / frequenz-dispatch-python

High-level interface to dispatch API
https://frequenz-floss.github.io/frequenz-dispatch-python/
MIT License
0 stars 3 forks source link

Update frequenz dependencies #23

Closed Marenz closed 5 months ago

Marenz commented 5 months ago

the use of replace instead of setting values

This is because the client-dispatch update changed Dispatch classes to frozen

and the removal of the YieldingSender

That is a good question. As the tests show, it doesn't seem to be needed anymore, I am not sure about the exact reason though. Maybe it was never actually required to begin with and I added it to solve a problem but actually a different changed fixed it?

shsms commented 5 months ago

split into 3 commits, why don't you want more stats in: https://github.com/frequenz-floss/frequenz-dispatch-python/graphs/contributors

Marenz commented 5 months ago

and the removal of the YieldingSender

It was removed because send() used to be async but isn't anymore in the latest version

shsms commented 5 months ago

send() in channels repo is still async, not sure if you mean something else, bit LGTM otherwise.

Marenz commented 5 months ago

send() in channels repo is still async, not sure if you mean something else, bit LGTM otherwise.

I don't even know at this point, but it works now :shrug: