search

frequenz-floss / frequenz-repo-config-python

Frequenz repository setup tools and common configuration for Python
https://frequenz-floss.github.io/frequenz-repo-config-python/
MIT License
3 stars 7 forks source link

Fix the condition to run the `nox-cross-arch-all` job #265

Closed llucax closed 2 months ago

llucax commented 2 months ago

The current condition makes the job skip unless there is a failure, which means we also skip on success, which is not right, as we want this job to succeed if the matrix job succeeds.

To fix this, we only skip if the nox-cross-arch matrix job was skipped and we run otherwise, failing the job if the matrix job was not successful. We also use the job name explicitly, as we only have one dependency and it is easier to reason about a string than about arrays.

For consistency reasons, and to avoid future surprises, we also make the nox-all job run on failures of its child jobs, even when it is not necessary for now as we are not skipping jobs in the nox matrix job.

llucax commented 2 months ago

Skipping release notes because the previous release notes are enough.

llucax commented 2 months ago

I tested this quite a bit in this PR, simulation skips, failures and successes, I hope it is really working properly now.

llucax commented 2 months ago

Fixed the quoting style in the if: condition (" is not supported) and also sneaked in a fix for a typo in labeler.yaml.

llucax commented 2 months ago

Damn, one golden test was not properly updated. Now it is green, but news a new approval :pray: