search

frequenz-floss / frequenz-sdk-python

Frequenz Python Software Development Kit (SDK)
https://frequenz-floss.github.io/frequenz-sdk-python/
MIT License
13 stars 17 forks source link

Use `start_delay` when creating the resampler `Timer` #556

Closed llucax closed 2 months ago

llucax commented 1 year ago

What's needed?

We needed to introduce a hack to make the timer start delayed so it can be synced with the resampler alignment. We need to remove that hack eventually.

Proposed solution

Update to a new channels version that supports adding a start delay to the timer.

Additional context

Fixes a hack introduced in:

matthias-wende-frequenz commented 11 months ago

@llucax is this done?

llucax commented 11 months ago

Nope, it might even need a new channels release first. Super low prio though, it is just code cleanup.

matthias-wende-frequenz commented 11 months ago

Can we move it to post 1.0 then?

llucax commented 11 months ago

I would leave it here for now, when upgrading to channels 1.0.0 it is probably trivial to change this as part of the upgrade.

matthias-wende-frequenz commented 10 months ago

I'm not sure if that works. The reason is that we can set a start_delay but we can't set the now when initializing the timer and thus we can't guaranty that the timer is accurately aligned.

llucax commented 10 months ago

What do you mean by set the now?

llucax commented 2 months ago

This will be resolved with #802.