frequenz-floss / frequenz-sdk-python

Frequenz Python Software Development Kit (SDK)
https://frequenz-floss.github.io/frequenz-sdk-python/
MIT License
13 stars 17 forks source link

Rename DataSourcingActor #785

Open matthias-wende-frequenz opened 10 months ago

matthias-wende-frequenz commented 10 months ago

What's needed?

When requesting a metric from a microgrid component one has to send a ComponentMetricRequest to the DataSourcingActor

We should rename this Actor to something that makes it immediately clear what it is doing especially w.r.t. to the upcoming API clients additions.

Proposed solution

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response

matthias-wende-frequenz commented 10 months ago

@llucax @shsms suggestions?

llucax commented 10 months ago

The idea of this actor was that it gets metrics from different sources, that was the reason for the generic name. But we can review that idea now that new APIs are coming up if the abstraction doesn't really work.

llucax commented 10 months ago

It is true that it is tied to component metrics, so it could be ComponentMetricSourcingActor. But the resampling actor is also tied to it. This also means if we have other data sources, we need also another resampling actor, which all brings me to the "I told you so" when I said we shouldn't tie the reampling actor to component metrics and just do the connection between the source and the resampling from outside of the actor instead of letting the actor do it itself :trollface:

shsms commented 10 months ago

It is true that it is tied to component metrics, so it could be ComponentMetricSourcingActor. But the resampling actor is also tied to it.

And continue calling it the data sourcing actor, like we do with the ComponentMetricsResamplingActor? That sounds good to me.