Closed llucax closed 1 month ago
Approved, but removed from the queue in case you want to react to the feedback
Updated:
dest_dir
only oncecopy_with_path
to copy_with_directories
and improved the docsreturn
in the commitsRe-enabling auto-merge.
When building the wheel, the setuptools file discovery feature runs before the
compile_betterproto
sub-command is run, so the files are not included in the resulting wheel.To overcome this issue we use a hack, by running the compile command early when the distribution options are being finalized, we make sure the files are present by the time the file discovery runs.
This is very hacky though, and even when it seems to work well in all tested cases (calling setuptools
`setup()
directly,build
,pip install
,pip install -e
), I wouldn't be very surprised if it breaks in the future, so we probably will have to have an eye on it.Unfortunately it seems there is no easy way to do this with setuptools:
This PR also includes some other improvements, including: