search

frerich / clcache

A compiler cache for MSVC, much like ccache for gcc
Other
325 stars 83 forks source link

Fixing pylint finding introduced by pylint 2.2 #335

Closed benjaminfuchs closed 5 years ago

benjaminfuchs commented 5 years ago

The unittest always run with the latest pylint version. The latest version causes new findings in this file:

tests\test_unit.py:436:0: W1403: Implicit string concatenation found in list (implicit-str-concat-in-sequence)
tests\test_unit.py:437:0: W1403: Implicit string concatenation found in list (implicit-str-concat-in-sequence)
tests\test_unit.py:438:0: W1403: Implicit string concatenation found in list (implicit-str-concat-in-sequence)
tests\test_unit.py:439:0: W1403: Implicit string concatenation found in list (implicit-str-concat-in-sequence)

More details can be found here: http://pylint.pycqa.org/en/latest/whatsnew/2.2.html

codecov-io commented 5 years ago

Codecov Report

Merging #335 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files           4        4           
  Lines        1290     1290           
  Branches      194      194           
=======================================
  Hits         1140     1140           
  Misses        111      111           
  Partials       39       39
Flag Coverage Δ
#integrationtests_memcached 67.09% <ø> (ø) :arrow_up:
#unittests 85.27% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ab5d78...e5b9740. Read the comment docs.

frerich commented 5 years ago

Thanks a lot for doing this grunt work - merged!