New English note names not recognized

[rpspringuel]

In LilyPond 2.19 the long English note names were revised, putting a - in front of them (i.e. asharp became a-sharp, aflatflat became a-flatflat, etc.). These new names are not currently recognized as valid note names.

First noticed in conjunction with wbsoft/frescobaldi#877, where the issue throws off the auto-completion tools for key signatures.

[uliska]

I didn’t originally see what's going on here, but Frescobaldi is still officially supporting the latest stable LilyPond release (i e. 2.18). Generally syntax changes in 2.19 are neither recognized in autocomplete nor syntax highlighting.

I wish there was an option to support both but this is a design decision.

The question is: are note names so important that we should break the rule?

[wbsoft]

I think I can add support for this without compromising compatibility with older LilyPond versions

[pimlottc]

This also causes errors when using the transpose command:

% cat simple.ly                 
\language "english"
\relative c' {
  b,8 b'8~ b2 a4 | g2~ g8 e( f-sharp g) |
}
% ly "transpose g c" ./simple.ly
\language "english"
\relative c, {
  e8 e'8~ e2 d4 | c2~ c8 a( bf-sharp c) |
}

Of course, there is no note named "bf-sharp" :P