Writing good commit messages

fresearchgroup / IP-based-hardware-infrastructure-management-for-cloud

GNU General Public License v3.0

2 stars 1 forks source link

Writing good commit messages #2

Open ghost opened 7 years ago

ghost commented 7 years ago

As of now all commit messages are somewhat vague... Go through this link to find out what a good commit message look like : http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

minaliup commented 7 years ago

Please refer to at least one commit message that you found vague.

ghost commented 7 years ago

there is no valid issue reference in any of the commits... and for one thing there are multiple commits... for example d999fb6c8f8fe9f8494d28bc02dd719bbe437fa4 and d012ac6e16d44a911d6a9215d2037fc60b152050

they perform the same actions... and there should not be two of them...

Also for example in these two commits 1ce3b610f63f8084c3bc6049dadc855914cd7e0a and 732f0c68d55319a4b95153769f9e4af123980f49 a little more description in commit message body would be helpful...

ghost commented 7 years ago

@mayank1010 Why did you close this issue ? The commits are still as it is and no changes or amends have been made... Don't close it unnecessarily just for the sake of having less number of issues...

This issue needs to be reopened... Please do so