fresh-standard / fresh-themes

Multiformat themes and skins for your technical résumé/CV.
MIT License
194 stars 63 forks source link

Add a 'contact' partial? #39

Open evanplaice opened 8 years ago

evanplaice commented 8 years ago

Not sure if dedicating a partial to contact info. Providing a default structure to display this info may improve DRY.

  "contact": {
    "email": "",
    "phone": "",
    "website": "",
    "other": [
      {
        "label": "",
        "flavor": "",
        "value": ""
      } 
    ]
  }
hacksalot commented 8 years ago

I've gone back and forth on this a bit but it's better to have a partial and not need it than need a partial and not have it, especially when building a new partial doesn't involve a lot of effort. This also mirrors the structure of the FRESH schema, where contact is a root-level element.

evanplaice commented 8 years ago

I agree. I suggested it because I think the basic template should just list all of the partials. Since you feel this way I'll add 2 more issues for sections that are currently missing but follow the same logic (ie location & social).

Then themes can customize the structure by adding their own. Such as the skills partial used in the 'modern' template.