fresh92 / cssmin

Automatically exported from code.google.com/p/cssmin
0 stars 0 forks source link

Regular expression are erroneous #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Run cssmin.php against test.css

What is the expected output? What do you see instead?
Expected output "E F{border:1px solid red;}"
Actual output "EF{border: 1px solid red;}"

What version of the product are you using? On what operating system?
The only released version as of today. Running on any operating system running 
PHP5.x

Please provide any additional information below.
The regular expressions lifted straight from jsmin.php are not suitable for css 
minification.  They 
are removing tabs (the whitespace between the E and F selectors) and not 
correctly removing 
whitespace surrounding colons). I suspect there are very many more errors that 
this small, 
individual test case does not reveal.

Original issue reported on code.google.com by jim.u.fl...@gmail.com on 14 Jul 2008 at 11:57

Attachments:

GoogleCodeExporter commented 8 years ago
Correction: regular expressions have not be lifted from jsmin but they are 
erroneous

Original comment by jim.u.fl...@gmail.com on 14 Jul 2008 at 12:00

GoogleCodeExporter commented 8 years ago
Thanks for you bug report.

I have to admit, that regular expressions are not one of my strenghts ;). This 
bug is
fixed in the version 1.0.1.b1 which is marked as beta because i did a complete
rewrite of the minify process.

So this version requires some testing to get stable. Any comments on the new 
version
are apriciated.

Original comment by joe.scylla on 7 Aug 2008 at 11:30