search

freshOS / Arrow

🏹 Parse JSON with style
MIT License
387 stars 27 forks source link

Adds NSURL parsing #10

Closed s4cha closed 8 years ago

s4cha commented 8 years ago

@maxkonovalov since you're a regular contributor I figured I'd make Pull requests as well so that we can discuss things together.

This transforms 

if let link = json["link"] as? String, url = NSURL(string:link)  {
    profile.link = link
}

into 

link <-- json["link"]

What do you think ?

maxkonovalov commented 8 years ago

Hey @s4cha, this is great, for some reason I thought that Arrow would support NSURL parsing already 😀 so this is a really welcome addition. 👏

BTW, I think you can assign the PRs you would like to review to me so that I merge and close them.

s4cha commented 8 years ago

@maxkonovalov nice! Unfortunately we can only assign contributors to PRs :( Let's keep it this way for now then ;)