Closed JuliusBahr closed 7 years ago
@JuliusBahr How come you don't have PR rights? That is a very welcome addition :)
No definitely not: git push origin feature/supportSwiftGen:feature/supportSwiftGen remote: Permission to freshOS/Localize.git denied to JuliusBahr. fatal: unable to access 'https://github.com/freshOS/Localize.git/': The requested URL returned error: 403
On 28 Mar 2017, at 15:54, S4cha notifications@github.com wrote:
@JuliusBahr https://github.com/JuliusBahr How come you don't have PR rights? That is a very welcome addition :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freshOS/Localize/issues/1#issuecomment-289777162, or mute the thread https://github.com/notifications/unsubscribe-auth/AQeZQCTfQ5nx6po259-G8nBZK0vWDNVjks5rqREhgaJpZM4MrkyV.
Hi @JuliusBahr, to submit a PR you need to fork the repo first, and then push the changes to a branch on your own repo. Hope this helps ;)
@JuliusBahr if you don't feel like making a PR we can update it ourselves based on the diff you provided and mention you :) What do you think?
yep, please go ahead and thanks
On 13. Apr 2017, at 11:37, S4cha notifications@github.com wrote:
@JuliusBahr https://github.com/JuliusBahr if you don't feel like making a PR we can update it ourselves based on the diff you provided and mention you :) What do you think?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freshOS/Localize/issues/1#issuecomment-293841568, or mute the thread https://github.com/notifications/unsubscribe-auth/AQeZQMnKWia6Fil5VIdsU1-vEFAb60eIks5rvezzgaJpZM4MrkyV.
@JuliusBahr the patch has been applied : https://github.com/freshOS/Localize/commit/9be6923918ab9a671c049f7e682e89c47212957a
Thanks a lot :)
Hey we use SwiftGen in our code base and I would like to use Localize too. I have created a patch that adds SwiftGen support and adds additional logging. Unfortunately I have no rights to create a PR, so I will paste below. With best regards
Julius