search

freshbooks / ember-responsive

Easy responsive layouts with Ember
https://freshbooks.github.io/ember-responsive/
MIT License
40 stars 19 forks source link

call this._super(...arguments) when overriding init method #144

Closed nightire closed 5 years ago

nightire commented 5 years ago

ember 3.11.0-beta will not tolerate overriding init method without calling this._super(...arguments), below will cause application break down:

https://github.com/freshbooks/ember-responsive/blob/613f89e35c88b2809ac3941a4dff01924e0083d6/addon/services/media.js#L123-L138

ryanto commented 5 years ago

👍 Just started seeing this as well in travis.

ryanto commented 5 years ago

PR here: https://github.com/freshbooks/ember-responsive/pull/145

k-fish commented 5 years ago

See #145