search

freshbooks / freshbooks-nodejs-sdk

Node.js SDK for the FreshBooks API
MIT License
8 stars 12 forks source link

Fix sdk "in" list filter query param generation #26

Closed amcintosh closed 3 years ago

amcintosh commented 3 years ago

It looks like we're not handling in filters correctly:

https://github.com/freshbooks/api-nodejs-sdk/blob/master/packages/api/src/models/builders/SearchQueryBuilder.ts#L27

This would generate a query_string in the for of: ?search[userids]=1&search[userids]=23

When the correct form for lists in evolve is: ?search[userids][]=1&search[userids][]=2&search[userids][]=3

amcintosh commented 3 years ago

Fixed