Regression in unreleased 0.6.0's Container dispose functinality

freshgum-bubbles / typedi

Elegant Dependency Injection in TypeScript and JavaScript.

http://typedi.js.org/

MIT License

53 stars 3 forks source link

Regression in unreleased 0.6.0's Container dispose functinality #124

Closed freshgum-bubbles closed 1 year ago

freshgum-bubbles commented 1 year ago

Describe the bug

In 0.6.0, the ContainerInstance.dispose method now correctly awaits the disposing of said container. Unfortunately, this seems to have introduced regressions in the test suite, which are still being investigated.

0.6.0 has not yet been released, so there's a window to fix these unexpected regressions before they go live.

freshgum-bubbles commented 1 year ago

Fixed by https://github.com/freshgum-bubbles/typedi/commit/174d15fa106cb0d06a074e8cfbbdd3828a09bb2f.

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.